-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature to bind on stream emits via options #18
Conversation
Adds feature to: request.defaults({ bindOn: { request: console.log } });
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes...
request.js
Outdated
|
||
// bind default events sent via options | ||
// additional postman feature starts | ||
if (options.bindOn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a stricter type check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see request library doing it anywhere
@shamasis |
|
* master: Update test certificates 2.87.1 Update changelog 2.87.0 Replace hawk dependency with a local implemenation (request#2943)
TODO: Add tests before stable release (CodeCov should be happy) |
Adds feature to:
request.defaults({
bindOn: { request: console.log }
});
PR Checklist:
npm test
locally and all tests are passing.PR Description